task(libs/accounts): Port email sending code to libs #19601
Draft
+3,614
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
force-pushed
the
FXA-12582
branch
2 times, most recently
from
87fe895 to
5af34cf
Compare
4 tasks
|
Same question as the errors port to libs - is there a follow-up to port the tests and run them in CI? |
Because: - We will need this for subsequent efforts This commit: - Ports `oauth/errors.js` and `errors.js` from auth-server to libs
Because: - We want need a standalone library that can be used to send emails This Commit: - Ports the email sending code from auth-server into libs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return false; | ||
| } | ||
|
|
||
| console.log('!!! ', routes, path, routes.findIndex((r) => { |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| } | ||
|
|
||
| console.log('!!! ', routes, path, routes.findIndex((r) => { | ||
| console.log(`/v1${r.path}`, path) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #19600
Because
auth-servercontextThis pull request
libs/accounts/email-senderfromauth-serverIssue that this pull request solves
Closes: FXA-12582
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
This is party of a multi part PR. The next part is email rendering.